[STJ SourceGen] Use Roslyn4.4 target when testing#79890
[STJ SourceGen] Use Roslyn4.4 target when testing#79890eiriktsarpalis wants to merge 2 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue Detailsnull
|
ViktorHofer
left a comment
There was a problem hiding this comment.
I'm OK with not testing the roslyn4.0 source generator for now. We do the same for target frameworks and only test the very latest. If we notice regressions in the roslyn4.0 source generator though (i.e. based on customer reports), we should invest in testing it as well.
|
I neglected to put in the description that I created this PR in order to isolate some wasm test failures I've been seeing: #79828 (comment) TL;DR running tests against Roslyn4.4 causes deterministic assertion failures when running release builds on wasm. I don't see how a compile time artifact such as the Roslyn version could trigger test failures at runtime, but I'll keep investigating. |
554c12b to
2d50ae5
Compare
2d50ae5 to
c1caeb1
Compare
c1caeb1 to
fe3a627
Compare
|
Hi @dotnet/mono-team, it looks like the changes introduced in 5236bb8 are causing a number of tests to fail on wasm only. I've been able to narrow down the failures to a single unit test in fe3a627. The failure happens deterministically and only occurs on wasm targets. It appears to occur because the |
Created this PR to try to isolate the test failures reported in #79828 (comment)