Unblock subsequent requests when an async over sync Dns call runs for too long#92863
Closed
antonfirsov wants to merge 9 commits intodotnet:mainfrom
Closed
Unblock subsequent requests when an async over sync Dns call runs for too long#92863antonfirsov wants to merge 9 commits intodotnet:mainfrom
antonfirsov wants to merge 9 commits intodotnet:mainfrom
Conversation
…/runtime into dns-queue-timeout-02 # Conflicts: # src/libraries/System.Net.NameResolution/src/System/Net/Dns.cs
ghost
assigned
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsThis is an alternative for #92862 in case we are willing to take a more intrusive fix for #81023. It replaces the queue of Tasks with a queue (linked list) of
|
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative for #92862 in case we are willing to take a more intrusive fix for #81023. It replaces the queue of Tasks with a queue (linked list) of
DnsRequestWaiter : TaskCompletionSourceobjects which store time-stamps. This allows signaling completion to (and unblock) subsequent tasks in case we detect that a request is long-running (> 1 sec).Fixes #81023
Fixes #92054
Fixes #92045