Conversation
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue Detailsnull
|
| if (json.HasValueSequence) | ||
| { | ||
| Assert.True(json.ValueSpan == default); | ||
| Assert.True(json.ValueSpan.IsEmpty); |
There was a problem hiding this comment.
I think these tests wants to really test for default. This build break should be fixed by pragma warning disable.
There was a problem hiding this comment.
Yeah that's my thinking too. I wanted to see if there are more breaks after these ones are fixed.
There was a problem hiding this comment.
Ah, the analyzer should be disabled for test projects, could you please add below rows here:
runtime/eng/CodeAnalysis.test.globalconfig
Lines 675 to 677 in b5b290f
# CA2265: Do not compare Span<T> to 'null' or 'default'
dotnet_diagnostic.CA2265.severity = none
There was a problem hiding this comment.
I see the analyzer updated reverted, this can be added later when analyzer updated
|
There are still more build issues this PR does not address, like in |
Draft PR because I'm not convinced this is the right fix.