add analytics_label in FcmOptions#303
Closed
chemidy wants to merge 4 commits intofirebase:masterfrom
chemidy:analytics_label
Closed
add analytics_label in FcmOptions#303chemidy wants to merge 4 commits intofirebase:masterfrom chemidy:analytics_label
chemidy wants to merge 4 commits intofirebase:masterfrom
chemidy:analytics_label
Conversation
added 4 commits
June 29, 2019 00:06
|
I came here to raise the same request. Thank you for that. Any rough idea when can we see this in pypi release? In terms of (weeks or months etc) |
Contributor
Author
|
I have to add tests and fix some bug in my PR before :) |
hiranya911
suggested changes
Jul 10, 2019
Contributor
hiranya911
left a comment
hiranya911
left a comment
There was a problem hiding this comment.
This looks rather incomplete. I don't see the code that handles JSON serialization of new types. Also no test cases for the new functionality.
| def __init__(self, analytics_label=None): | ||
| self.analytics_label = analytics_label | ||
|
|
||
| class FcmOptions(object): |
Contributor
There was a problem hiding this comment.
Add one more empty line.
|
|
||
| def __init__(self, analytics_label=None): | ||
| self.analytics_label = analytics_label | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-add analytics_label in FcmOptions
#301