flatcar-postinst: create reboot-required flag file for kured#15
Merged
pothos merged 1 commit intoflatcar-masterfrom Dec 7, 2021
Merged
flatcar-postinst: create reboot-required flag file for kured#15pothos merged 1 commit intoflatcar-masterfrom
pothos merged 1 commit intoflatcar-masterfrom
Conversation
invidian
approved these changes
Dec 6, 2021
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Dec 6, 2021
This pulls in flatcar/update_engine#15 to create the Ubuntu-compatible /run/reboot-required flag file for kured.
Merged
1 task
tormath1
approved these changes
Dec 6, 2021
Contributor
tormath1
left a comment
tormath1
left a comment
There was a problem hiding this comment.
LGTM and it's not harmful. :)
While locksmithd and FLUO interact with update-engine through DBus, kured looks for Ubuntu's /run/reboot-required flag file. Support kured by creating the flag file in the update post-install action.
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Dec 6, 2021
This pulls in flatcar/update_engine#15 to create the Ubuntu-compatible /run/reboot-required flag file for kured.
invidian
reviewed
Dec 6, 2021
| echo "Setup ${INSTALL_LABEL} (${INSTALL_DEV}) for next boot." | ||
|
|
||
| # Create the Ubuntu-compatible /run/reboot-required flag file for kured | ||
| touch /run/reboot-required |
Member
There was a problem hiding this comment.
Can/Should this be tested somehow?
Member
Author
There was a problem hiding this comment.
At least I want to run a test with using the OEM hook that gets called earlier. I'll also try to run kured manually on a built image and will merge when done.
Member
Author
There was a problem hiding this comment.
Running the kured container without K8s doesn't really work easily but I checked that the file gets created.
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Dec 7, 2021
This pulls in flatcar/update_engine#15 to create the Ubuntu-compatible /run/reboot-required flag file for kured.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While locksmithd and FLUO interact with update-engine through DBus,
kured looks for Ubuntu's /run/reboot-required flag file.
Support kured by creating the flag file in the update post-install
action.
How to use
Apply an update with
flatcar-updateand see that kured will reboot the machine.Testing done
Booted the built image and updated to it:
changelog/directory (user-facing change, bug fix, security fix, update)↑ will do in coreos-overlay