This repository was archived by the owner on May 30, 2023. It is now read-only.
Merged
Conversation
Contributor
Author
|
The error is: and after unmasking similar with virtual/cdrtools. |
dongsupark
approved these changes
Nov 10, 2021
Contributor
dongsupark
left a comment
dongsupark
left a comment
There was a problem hiding this comment.
Thanks for catching that issue.
See below:
dongsupark
reviewed
Nov 10, 2021
The recent keyword cleanup removed two keywords that are necessary to bootstrap an arm64 sdk: open-vmdk and virtual/cdrtools. Restore them. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
jepio
force-pushed
the
jepio/arm64-sdk-keywords
branch
from
47dc477 to
d04f69c
Compare
dongsupark
approved these changes
Nov 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
profiles: add missing arm64 sdk keywords
The recent keyword cleanup removed two keywords that are necessary to
bootstrap an arm64 sdk: open-vmdk and virtual/cdrtools. Restore them.
How to use
No real great way, because we don't have automated sdk bootstrap for arm64 yet.
Testing done
Tested that
./boostrap_sdk stage4starts instead of failing due to unmet dependencies.