This repository was archived by the owner on May 30, 2023. It is now read-only.
app-arch/torcx: Fix wrong reference to Docker 19.03#1456
Merged
Conversation
jepio
approved these changes
Dec 1, 2021
Contributor
jepio
left a comment
jepio
left a comment
There was a problem hiding this comment.
What's the role of the docker-1.12 profile anyway?
Contributor
Author
Torcx knows about the file |
When selecting the docker-1.12-no profile, torcx failed because the profile looked for 19.03 instead of 20.10. Make the docker-1.12-no profile identical to the vendor profile so that we don't have to update it.
pothos
force-pushed
the
kai/torcx-no-docker-1.12
branch
from
7273d35 to
adf807d
Compare
pothos
added a commit
that referenced
this pull request
Dec 2, 2021
app-arch/torcx: Fix wrong reference to Docker 19.03
pothos
added a commit
that referenced
this pull request
Dec 2, 2021
app-arch/torcx: Fix wrong reference to Docker 19.03
pothos
added a commit
that referenced
this pull request
Dec 2, 2021
app-arch/torcx: Fix wrong reference to Docker 19.03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When selecting the docker-1.12-no profile, torcx failed because the
profile looked for 19.03 instead of 20.10.
Make the docker-1.12-no profile identical to the vendor profile so
that we don't have to update it.
How to use
Check that
works again.
Backport to Stable, Beta, Alpha.
Testing done
build scheduled, ran the above test
changelog/directory (user-facing change, bug fix, security fix, update)