This repository was archived by the owner on May 30, 2023. It is now read-only.
Merge Pro features into the regular image#1679
Merged
sayanchowdhury merged 8 commits intomainfrom Mar 2, 2022
Merged
Conversation
krnowak
approved these changes
Feb 28, 2022
Contributor
krnowak
left a comment
krnowak
left a comment
There was a problem hiding this comment.
Looks good, but I think it also needs to companion PR to scripts, where we drop azure_pro, ami_vmdk_pro and maybe gce_pro from VALID_IMG_TYPES in build_library/vm_image_util.sh and from the list in jenkins/formats-amd64-usr.txt.
Contributor
Author
|
@krnowak We would continue to ship the Flatcar Pro images. I've done some changes so that it uses the params of the regular images - https://github.com/flatcar-linux/scripts/pull/241/files |
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
sayanchowdhury
force-pushed
the
sayan/merge-pro-in-regular
branch
from
1090532 to
745738a
Compare
Merged
1 task
krnowak
approved these changes
Mar 2, 2022
pothos
added a commit
that referenced
this pull request
Apr 28, 2022
Merge Pro features into the regular image
pothos
added a commit
that referenced
this pull request
Apr 28, 2022
Merge Pro features into the regular image
Contributor
|
Cherry-picking this for flatcar-3033 and flatcar-3139 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge the Pro features into the regular image
The Pro image contains a few enhancements which is not present in the regular Flatcar images. This PR brings all those enhancements into the regular image.
This PR also updates the NVIDIA drivers to 510.47.03
Testing done
Jenkins CI http://jenkins.infra.kinvolk.io:8080/job/os/job/manifest/4959/cldsv/
changelog/directory (user-facing change, bug fix, security fix, update)