This repository was archived by the owner on May 30, 2023. It is now read-only.
coreos-base/oem-gce: bring back shutdown scripts#1912
Merged
Conversation
In the `init.sh` of the OEM GCE container, we have the following
section:
```bash
wait -n "${daemon_pids[@]}" || :
kill "${daemon_pids[@]}" || :
test -n "$stopping" || exit 1
exec /usr/bin/google_metadata_script_runner --script-type shutdown
```
`shutdown` script was not executed because container was receiving a
`SIGKILL`, the started processes was not properly terminated.
According to the `systemd-nspawn` manual:
```bash
If --boot is not used and this option is not specified
the container's processes are terminated abruptly via SIGKILL
```
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
krnowak
approved these changes
May 23, 2022
Contributor
Author
|
cherry-picked to:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the
init.shof the OEM GCE container, we have the followingsection:
shutdownscript was not executed because container was receiving aSIGKILL, the started processes was not properly terminated.According to the
systemd-nspawnmanual:If --boot is not used and this option is not specified the container's processes are terminated abruptly via SIGKILLSigned-off-by: Mathieu Tortuyaux mtortuyaux@microsoft.com
Testing done
Added a
shutdown-scriptto the GCP metadata server, edited theoem-gceto add the--kill-signal=SIGTERM, manually stopped the service and see theshutdown-scriptbeing executed in the logs:changelog/directory (user-facing change, bug fix, security fix, update)Closes: flatcar/Flatcar#743