sys-apps/ignition: bring back noop OEM

[tormath1]

it mainly brings back Vagrant which was failing with Ignition 2.14.0 even if no Ignition is provided.

Signed-off-by: Mathieu Tortuyaux mtortuyaux@microsoft.com

---

• Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
• Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.
• CI: http://jenkins.infra.kinvolk.io:8080/job/container/job/packages_all_arches/947/cldsv/

NOTE: It's ok to me to backport on all channels: the added platforms were not just working before.

Related to: flatcar/Flatcar#916

[krnowak]

I'm wondering if this shouldn't be fixed by using noop.FetchConfig for the unregistered platforms, but I suppose this is outside the scope of this PR.

[tormath1]

I'm wondering if this shouldn't be fixed by using noop.FetchConfig for the unregistered platforms, but I suppose this is outside the scope of this PR.

What do you mean by that?

[krnowak]

I'm wondering if this shouldn't be fixed by using noop.FetchConfig for the unregistered platforms, but I suppose this is outside the scope of this PR.

What do you mean by that?

Basically if somewhere in Ignition code there should be a snippet like (instead of trying to list all the old platforms):

if config, ok := configs.getConfigForPlatformOrSomething(platformName); ok {
    config.fetch(…)
} else {
    # platform not registered, assume noop.FetchConfig will be enough for its needs
    noop.FetchConfig(…)
}

But wrt. Ignition, I'm an uninformed keyboard puncher here, so I might be spouting nonsense. :)

[tormath1]

@krnowak I'll go ahead for now - this is something we can suggest and track directly into the upstream coreos/ignition repo. :)

[tormath1]

picked to:

• flatcar-3446
• flatcar-3432

As it concerns Ignition, I think it's safer to test in Beta before picking it to stable.

[krnowak]

@krnowak I'll go ahead for now - this is something we can suggest and track directly into the upstream coreos/ignition repo. :)

Sure, sounds good.