Skip to content
This repository was archived by the owner on May 30, 2023. It is now read-only.

add qedf, qedi, qla4xxx modules#528

Merged
t-lo merged 1 commit intomainfrom
t-lo/add-qedf-qedi-qla4xxx
Aug 18, 2020
Merged

add qedf, qedi, qla4xxx modules#528
t-lo merged 1 commit intomainfrom
t-lo/add-qedf-qedi-qla4xxx

Conversation

@t-lo
Copy link
Contributor

@t-lo t-lo commented Aug 14, 2020

Add qedf, qedi, qla4xxx kernel modules

This PR adds support for QLogic qedf, qedi, and qla4xxx SCSI devices via CONFIG_QEDF, CONFIG_QEDI, CONFIG_SCSI_QLA_ISCSI respectively. Addressess flatcar/Flatcar#165 .

Testing done

  1. built a custom Flatcar Container Linux OS image based on the Alpha 2592.0.0 SDK.
  2. in the resulting qemu image, ran `modprobe qedf; modprobe qedi; modprobe qla4xxx
  3. ran dmesg - no errors reported, and lsmod to validate modules were loaded
  4. did not verify functionally because of lack of access to hardware
  5. Build system acceptance tests are still todo / pending (hence PR is in draft mode)

Signed-off-by: Thilo Fromm <thilo@kinvolk.io>
@t-lo t-lo requested a review from a team August 14, 2020 17:53
@t-lo t-lo added the main label Aug 14, 2020
@t-lo t-lo marked this pull request as ready for review August 18, 2020 09:51
@t-lo t-lo merged commit 78905e9 into main Aug 18, 2020
@t-lo t-lo deleted the t-lo/add-qedf-qedi-qla4xxx branch August 18, 2020 10:20
@simonello
Copy link

simonello commented Aug 19, 2020

Can you please let me know when this is going to be released? I can test these modules on my hardware if needs be. If so, can you just point me to the iso.

@margamanterola
Copy link
Contributor

We are working on a new major Alpha release that will include this change as well as a few others (version 2605). We're still ironing out the last details, but expect it to go out in the next couple of days.

@simonello
Copy link

simonello commented Aug 21, 2020

Thank you. I saw the new alpha release.

I got the error "Target block device /dev/mapper/mpatha is not a full disk". I had to change line 360 in the /usr/bin/coreos-install script and add mpath.

if ! [[ $(lsblk -n -d -o TYPE "${DEVICE}") =~ ^(disk|loop|lvm|mpath)$ ]]; then

After that the install was good.

localhost ~ # lsmod |grep qedf
qedf 114688 3
libfcoe 65536 1 qedf
libfc 135168 2 qedf,libfcoe
scsi_transport_fc 57344 2 qedf,libfc
qed 602112 2 qedf,qede
scsi_mod 217088 9 qedf,ses,scsi_transport_sas,sd_mod,scsi_transport_fc,usb_storage,libfc,uas,sr_mod

@dongsupark
Copy link
Contributor

I got the error "Target block device /dev/mapper/mpatha is not a full disk". I had to change line 360 in the /usr/bin/coreos-install script and add mpath.

Can you please create a PR to change https://github.com/flatcar-linux/init/blob/flatcar-master/bin/flatcar-install ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments