Skip to content
This repository was archived by the owner on May 30, 2023. It is now read-only.

Comments

sys-kernel/coreos-firmware: Disable savedconfig flag and file creation#613

Merged
pothos merged 1 commit intomainfrom
kai/firmware-no-savedconfig
Sep 28, 2020
Merged

sys-kernel/coreos-firmware: Disable savedconfig flag and file creation#613
pothos merged 1 commit intomainfrom
kai/firmware-no-savedconfig

Conversation

@pothos
Copy link
Contributor

@pothos pothos commented Sep 25, 2020

The savedconfig feature reads and, if not set, generates a file under
/etc/portage/savedconfig/ to source a build configuration. We probably
don't want this and specially not on the final image, therefore,
disable reading and also don't write the file to the final image.

Note: Pick for 2605, 2632, and 2643

How to use

Build an image and check if /etc/portage exists which it shouldn't.

Testing done

Built an image and saw that the file is gone.

@pothos pothos force-pushed the kai/firmware-no-savedconfig branch from 97cf608 to 788dc56 Compare September 25, 2020 20:06
@pothos pothos changed the title sys-kernel/coreos-firmware: Disable savedconfig flag sys-kernel/coreos-firmware: Disable savedconfig flag and file creation Sep 25, 2020
@pothos pothos marked this pull request as ready for review September 25, 2020 20:09
@pothos pothos requested a review from a team September 25, 2020 20:09
The savedconfig feature reads and, if not set, generates a file under
/etc/portage/savedconfig/ to source a build configuration. We probably
don't want this and specially not on the final image, therefore,
disable reading and also don't write the file to the final image.
@pothos pothos force-pushed the kai/firmware-no-savedconfig branch from 788dc56 to d5dfe3b Compare September 28, 2020 09:25
Copy link
Contributor

@margamanterola margamanterola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pothos pothos merged commit ba19f5e into main Sep 28, 2020
@pothos pothos deleted the kai/firmware-no-savedconfig branch September 28, 2020 10:05
pothos added a commit that referenced this pull request Sep 28, 2020
sys-kernel/coreos-firmware: Disable savedconfig flag and file creation by pothos
pothos added a commit that referenced this pull request Sep 28, 2020
sys-kernel/coreos-firmware: Disable savedconfig flag and file creation by pothos
pothos added a commit that referenced this pull request Sep 28, 2020
sys-kernel/coreos-firmware: Disable savedconfig flag and file creation by pothos
pothos added a commit that referenced this pull request Oct 8, 2020
sys-kernel/coreos-firmware: Disable savedconfig flag and file creation by pothos
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants