This repository was archived by the owner on May 30, 2023. It is now read-only.
coreos-base/afterburn: Restart on failure and keep unit active#768
Merged
coreos-base/afterburn: Restart on failure and keep unit active#768
Conversation
When the metadata server is unavailable for some time the service did not retry. Also, the service was triggered possibly multiple times each time another service pulled it in which can cause problems if, e.g., the service experiences a failure and corrupts the existing file which could have been kept because rerunning wasn't needed. Fixes flatcar/Flatcar#311
sayanchowdhury
approved these changes
Jan 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the metadata server is unavailable for some time the service did
not retry. Also, the service was triggered possibly multiple times
each time another service pulled it in which can cause problems if,
e.g., the service experiences a failure and corrupts the existing file
which could have been kept because rerunning wasn't needed.
Fixes flatcar/Flatcar#311
How to use
Build and verify that all tests pass
Testing done
None