This repository was archived by the owner on May 30, 2023. It is now read-only.
Enable MDIO_BCM_UNIMAC for arm64#929
Merged
jepio merged 1 commit intoflatcar-archive:mainfrom Jul 13, 2021
Merged
Conversation
…earlier stages like PXE/UEFI boot
jepio
approved these changes
Jul 13, 2021
Contributor
jepio
left a comment
jepio
left a comment
There was a problem hiding this comment.
CONFIG_BCMGENET specifies select MDIO_BCM_UNIMAC so this setting was already active before, but it is a good idea to be explicit about what we want enabled. I'll look into the dracut update next.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flatcar/Flatcar#375
How to use
This flag is missing for BCM so the MAC can get reused after already being used by other stages such as iPXE. You can run flatcar with iPXE as noted in the original issue
Testing done
While the flag should work I can't test it because it is not included due to another upstream bug related to dracut and linux. Looking at portage-stable flatcar is running dracut-050. At least version 052 is needed to fix this. See dracutdevs/dracut@c8be886