Skip to content
This repository was archived by the owner on May 30, 2023. It is now read-only.

Comments

sys-fs/cryptsetup: enable fips on stable#312

Merged
tormath1 merged 2 commits intoflatcar-3033from
tormath1/cryptsetup
Mar 23, 2022
Merged

sys-fs/cryptsetup: enable fips on stable#312
tormath1 merged 2 commits intoflatcar-3033from
tormath1/cryptsetup

Conversation

@tormath1
Copy link
Contributor

@tormath1 tormath1 commented Mar 23, 2022

this is required to enable fips mode on cryptsetup for stable release.

Signed-off-by: Mathieu Tortuyaux mtortuyaux@microsoft.com


@pothos
Copy link
Contributor

pothos commented Mar 23, 2022

Since we only backport something that will be present when updating to a newer version I think it would be nice to have this stay in portage-stable. The move makes it harder to cherry-pick in the future.

Downstream patches that are not upstreamed to Gentoo would be lost on update but here this is probably not the case anymore because the newer versions have the flag.

@tormath1
Copy link
Contributor Author

Since we only backport something that will be present when updating to a newer version I think it would be nice to have this stay in portage-stable. The move makes it harder to cherry-pick in the future.

Downstream patches that are not upstreamed to Gentoo would be lost on update but here this is probably not the case anymore because the newer versions have the flag.

@pothos I think I understand your point - but why would we need to cherry-pick this commits ? To me, once in Stable it should not have to move ?
Since this commits will be on flatcar-3033 they should not interfere with future versions of cryptsetup.

@pothos
Copy link
Contributor

pothos commented Mar 23, 2022

In the past there were cases where we updated software on the stable branch and for the LTS branch it is even a bit more likely that this can happen. Anyway, I just thought it can spare us some work and make diffing easier because I don't really see a benefit in the move.

@tormath1
Copy link
Contributor Author

@pothos it was mostly to stay consistent with the concept of: flatcar modification -> ::coreos-overlay. Once the CI done, I'll move back cryptsetup to this overlay and simply apply the following commit on it: flatcar-archive/coreos-overlay@5495dbf

enable FIPS mode

Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
@tormath1 tormath1 force-pushed the tormath1/cryptsetup branch from 952f13c to ead3c93 Compare March 23, 2022 16:20
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
@tormath1 tormath1 marked this pull request as ready for review March 23, 2022 16:25
@tormath1 tormath1 requested a review from a team March 23, 2022 16:25
@tormath1 tormath1 merged commit fdffe0f into flatcar-3033 Mar 23, 2022
@tormath1 tormath1 deleted the tormath1/cryptsetup branch March 23, 2022 17:49
@tormath1 tormath1 changed the title sys-fs/cryptsetup: move to ::coreos-overlay sys-fs/cryptsetup: enable fips on stable Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants