Upgrade Go to v1.12.4

[zmoazeni]

Related issue: #727

Description

This PR upgrades gh-ost to v1.12.4

Some notes

I ran ./script/cibuild-gh-ost-replica-tests and ran into some flakey failures in the v5.5.x MySQL line. Primarily around datetime-1970 and mixed-charset. I'm not seeing those tests in TravisCI. Do you run those on a private box?

I extended the script to allow us to pass a filter for the specific test and they intermittently seemed to be fine/fail individually (more often than not, they passed). So that has me scratching my head a little.

diff --git a/script/cibuild-gh-ost-replica-tests b/script/cibuild-gh-ost-replica-tests
index ab8c689..2d73f1c 100755
--- a/script/cibuild-gh-ost-replica-tests
+++ b/script/cibuild-gh-ost-replica-tests
@@ -22,6 +22,9 @@ test_mysql_version() {
   local mysql_version
   mysql_version="$1"
 
+  local test_filter
+  test_filter="$2"
+
   echo "##### Testing $mysql_version"
 
   echo "### Setting up sandbox for $mysql_version"
@@ -53,7 +56,7 @@ test_mysql_version() {
   gh-ost-test-mysql-master -uroot -e "grant all on *.* to 'gh-ost'@'%' identified by 'gh-ost'"
 
   echo "### Running gh-ost tests for $mysql_version"
-  ./localtests/test.sh -b bin/gh-ost
+  ./localtests/test.sh -b bin/gh-ost $test_filter
 
   find sandboxes -name "stop_all" | bash
 }
@@ -62,5 +65,5 @@ echo "Building..."
 . script/build
 # Test all versions:
 find gh-ost-ci-env/mysql-tarballs/ -name "*.tar.gz" | while read f ; do basename $f ".tar.gz" ; done | sort -r | while read mysql_version ; do
-  test_mysql_version "$mysql_version"
+  test_mysql_version "$mysql_version" "$1"
 done

Let me know if you're in favor of that diff, and I'll issue a separate PR for it

[zmoazeni]

Ahh doh! I did see go/logic/server.go:147:4: Fprintln arg list ends with redundant newline locally. I'll work on fixing that. Sorry about the intermediate noise.

[zmoazeni]

I first just dropped the newline, but then I realized it would change the output here. So I went the Fprintf() route AND had to escape the 70% r... part of the string

[shlomi-noach]

I'm not seeing those tests in TravisCI. Do you run those on a private box?

Yes. On Travis they take more than 1 hour to run. The tests (logic + data) are public, just running them on an internal box.

[shlomi-noach]

some flakey failures in the v5.5.x MySQL line. Primarily around datetime-1970 and mixed-charset

This bothers me. This would be the third time those sepcific tests turn flaky. I fixed them twice in the past.

[shlomi-noach]

I've pushed this branch to our git repo, which will kick the gh-ost-replica-tests suite.

[zmoazeni]

This bothers me. This would be the third time those sepcific tests turn flaky. I fixed them twice in the past.

Hrm bummer. I was pretty sure it's not the upgrade itself that is causing the intermittent failures. I might poke at them to see if I can see what's happening on my side. Do you remember any PRs that you created as part of your fixes?

[timvaillancourt]

@zmoazeni the repo has been updated to Go v1.14.7. Is this still required and could you update the PR if it is? 🙇

[zmoazeni]

@timvaillancourt I'm going to close it unmerged. I don't have the cycles to put into it these days.

[shlomi-noach]

I don't have the cycles to put into it these days.

@zmoazeni I told you so ❤️

[zmoazeni]

@shlomi-noach