delete minor unreachable code caused by t.Fatal#1047
Open
Abirdcfly wants to merge 1 commit intogoogle:masterfrom
Open
delete minor unreachable code caused by t.Fatal#1047Abirdcfly wants to merge 1 commit intogoogle:masterfrom
Abirdcfly wants to merge 1 commit intogoogle:masterfrom
Conversation
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
rski
reviewed
Aug 22, 2022
| _, err := defrag.DefragIPv4(&ip2) | ||
| if err != nil { | ||
| t.Fatal(err) | ||
| t.Fatalf("defrag: Maximum length is supposed to be 65535") |
There was a problem hiding this comment.
it would be good for debugging if the error were still printed, that can be done either by changing the removed Fatal to Error instead of removing or by adding the error to the next Fatalf.
rski
reviewed
Aug 22, 2022
| _, err := defrag.DefragIPv4(&ip2) | ||
| if err != nil { | ||
| t.Fatal(err) | ||
| t.Fatalf("defrag: Maximum length is supposed to be 65535") |
There was a problem hiding this comment.
This Fatalf could be Fatal since it doesn't format anything
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Abirdcfly fp544037857@gmail.com