fix: allow logs to propagate upstream for caplog testing#1374
Merged
mukund-ananthu merged 2 commits intomainfrom Mar 10, 2025
Merged
fix: allow logs to propagate upstream for caplog testing#1374mukund-ananthu merged 2 commits intomainfrom
mukund-ananthu merged 2 commits intomainfrom
Conversation
parthea
approved these changes
Mar 6, 2025
mukund-ananthu
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When tests are run in parallel and a base logger is not configured, then the log propagation from the base logger (i.e. a
googlenamed logger) to the root logger is disabled (this happens during client construction):Given that the above is a global config, any of the tests that use the caplog fixture start to fail once the propagation of logs to the root logger is disabled. This means that nothing is captured for a logger (by caplog) if it does not propagate to the root logger. See pytest-dev/pytest#3697.
As a workaround, we can allow propagation of logs to the root logger for a test run and then revert it to the original value once the test completes.
Fixes: b/388826364
Note: By default, log propagation to the root logger is disabled. This behaviour is captured in the
README.