Skip to content

feat: IAM signBlob retry and universe domain support#1380

Merged
cojenco merged 5 commits intogoogleapis:mainfrom
cojenco:retry-iam-sign
Nov 20, 2024
Merged

feat: IAM signBlob retry and universe domain support#1380
cojenco merged 5 commits intogoogleapis:mainfrom
cojenco:retry-iam-sign

Conversation

@cojenco
Copy link
Contributor

@cojenco cojenco commented Nov 12, 2024

No description provided.

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/python-storage API. labels Nov 12, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Nov 16, 2024
@cojenco cojenco changed the title feat: IAM signBlob retries feat: IAM signBlob retry and universe domain support Nov 16, 2024
@cojenco cojenco marked this pull request as ready for review November 18, 2024 20:03
@cojenco cojenco requested a review from a team as a code owner November 18, 2024 20:03
@cojenco cojenco requested a review from a team November 18, 2024 20:03
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 20, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 20, 2024
Copy link
Contributor

@sydney-munro sydney-munro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would probably be best if @andrewsg also got a look at it

Copy link
Contributor

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 20, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 20, 2024
@cojenco cojenco merged commit abc8061 into googleapis:main Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/python-storage API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants