PullRequest Reviews may not have submitted_at field#450
Closed
ssanj wants to merge 2 commits intohaskell-github:masterfrom
Closed
PullRequest Reviews may not have submitted_at field#450ssanj wants to merge 2 commits intohaskell-github:masterfrom
ssanj wants to merge 2 commits intohaskell-github:masterfrom
Conversation
Contributor
|
I rebased and merged in #462, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
submitted_atfield in the PullRequest Review is currently decoded as mandatory:https://github.com/phadej/github/blob/1119ad464706810e9b7db47b93d0b6a46dafbda8/src/GitHub/Data/Reviews.hs#L50
The Github API documentation states that:
I was bitten by this bug on Friday, where I was retrieving a Review in PENDING state.
I'm happy to get some pointers on the implementation.