[12.x] Add callback to customize fresh timestamp creation for all models#58620
Closed
AndrewMast wants to merge 1 commit intolaravel:12.xfrom
Closed
[12.x] Add callback to customize fresh timestamp creation for all models#58620AndrewMast wants to merge 1 commit intolaravel:12.xfrom
AndrewMast wants to merge 1 commit intolaravel:12.xfrom
Conversation
Member
|
Merged other PR. |
Contributor
|
@AndrewMast Thanks but I only wanted to get a consistent default behavior across all supported databases. Nevertheless, the changing the timestamp format across all models can be useful if someone needs high resolution timestamps with microseconds. Only the freshTimestampsWithoutMicroseconds() method isn't necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to PR #58614.
Why
Like @aimeos pointed out in the PR, sometimes the implementation for creating fresh timestamps needs to be changed. While this can be accomplished by overriding the
freshTimestampmethod for a specific model, you might need to change the behavior for all models, in the case with storing timestamp values into a SQL Server database.This PR adds a
Model::freshTimestampsUsing($callback);method to accomplish this. It also adds aModel::freshTimestampsWithoutMicroseconds();method to simply change the fresh timestamp logic toDate::now()->startOfSecond(), like @aimeos originally had in their PR.What
Added the following to
HasTimestampstrait to allow for a custom fresh timestamps callback:And updated
freshTimestampto use the callback:Tests
Still working on tests, would appreciate tips as I don't write tests often.