[wip] change limactl start timeout as command args#766
Closed
Abirdcfly wants to merge 1 commit intolima-vm:masterfrom
Closed
[wip] change limactl start timeout as command args#766Abirdcfly wants to merge 1 commit intolima-vm:masterfrom
Abirdcfly wants to merge 1 commit intolima-vm:masterfrom
Conversation
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
Abirdcfly
changed the title
AkihiroSuda
requested changes
Mar 29, 2022
Member
AkihiroSuda
left a comment
AkihiroSuda
left a comment
There was a problem hiding this comment.
The timeout has to be set after completion of downloading the image and the containerd archive.
Otherwise downloading will easily fail.
Member
|
Also, please use real name for signing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The source code has a hard-coded 10-minute timeout, which interferes with situations such as when the initialization command is time-consuming, or when the network conditions are simply not good