fix: MSBuildTask ignores props passing to CLI args#1384
Closed
guitarrapc wants to merge 2 commits intomicrosoft:mainfrom
Closed
fix: MSBuildTask ignores props passing to CLI args#1384guitarrapc wants to merge 2 commits intomicrosoft:mainfrom
guitarrapc wants to merge 2 commits intomicrosoft:mainfrom
Conversation
The FetchLicenseInformation and EnablePackageMetadataParsing properties can now be controlled via MSBuild. Fixes a bug where these properties were being ignored, resulting in potentially incorrect behavior of the SBOM generation. No breaking changes are introduced.
…geMetadataParsing Adds tests to validate SBOM generation when fetching license information and parsing package metadata is enabled. This ensures that the generated SBOM includes the expected license and supplier information.
|
According to README.md, "This project does not accept open-source contributions due to the sensitive, regulatory nature of SBOMs." |
Author
|
Oh, I didn’t catch that, thanks! Let's close PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The FetchLicenseInformation and EnablePackageMetadataParsing properties can now be controlled via MSBuild. Fixes a bug where these properties were being ignored, resulting in potentially incorrect behavior of the SBOM generation.
No breaking changes are introduced.
fixes: #718