Add isPreferred to the CodeAction protocol.#489
Closed
Jason3S wants to merge 3 commits intomicrosoft:masterfrom
Jason3S:CodeAction.isPreferred
Closed
Add isPreferred to the CodeAction protocol.#489Jason3S wants to merge 3 commits intomicrosoft:masterfrom Jason3S:CodeAction.isPreferred
Jason3S wants to merge 3 commits intomicrosoft:masterfrom
Jason3S:CodeAction.isPreferred
Conversation
See [vscode isPreferred discussion](microsoft/vscode#62110 (comment))
|
|
Member
|
For this to be merged we need to update the spec as well (see https://github.com/Microsoft/language-server-protocol/blob/gh-pages/specification.md#L1). In addition I think this needs to be guarded by a client capability so the server can decided if it is worthwhile to compute the property (in this case inexpensive but this is how the spec works today). |
Author
|
I have updated the spec and I added |
Author
|
@dbaeumer Is there more I need to do? |
rcjsuen
reviewed
May 3, 2019
Author
Member
|
Merged by hand with some minor modifications for consistency (e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See vscode isPreferred discussion