Fixed issue #108301 by escaping URI before creating a MarkdownString.

[samrg123]

Fixed issue #108301 by escaping URI with 'encodeURI' before creating a MarkdownString in 'TerminalLinkManager.ts::_getLinkHoverString'.

You can test the original bug and fix by creating an extension that registers a TerminalLinkProvider that returns a TerminalLink spanning a space.

The extension activate function I used for testing was:

export function activate(context: vscode.ExtensionContext) {

	// Use the console to output diagnostic information (console.log) and errors (console.error)
	// This line of code will only be executed once when your extension is activated
	console.log('Congratulations, your extension "terminallinktest" is now active!');


	vscode.window.activeTerminal?.show();


	vscode.window.registerTerminalLinkProvider({
		provideTerminalLinks: (context, token) => {

			return [{
				startIndex: 0,
				length: 10,
				tooltip: "crash the tooltip"
			}];
		},

		handleTerminalLink: (link: any) => { }
	});

	// The command has been defined in the package.json file
	// Now provide the implementation of the command with registerCommand
	// The commandId parameter must match the command field in package.json
	let disposable = vscode.commands.registerCommand('terminallinktest.testLink', () => {
		// The code you place here will be executed every time your command is executed

		vscode.window.showInformationMessage("Hello from termainLinkTest");

		// const crashPrefix = "package:test_api/src/frontend/expect.dart";
		// const crashMiddle = " 154:30";
		// const crashSuffix = "		fail";
		// const crashString = crashPrefix + crashMiddle + crashSuffix;

		let text = "";

		// Send all ascii chars
		for(var i = 32; i < 300; ++i) {

			let message = i+":";

			// escape quotes and ticks
			if(i === 34 || i === 96) {
				message = "'"+message+"\\"+String.fromCharCode(i)+"'";

			// escape "'"
			} else if(i === 39) {

				message = '"'+message+'\'"';

			// default
			} else {
				message = "'"+message+String.fromCharCode(i)+"'";
			}

			text+= message+" ";
		}

		vscode.window.activeTerminal?.sendText("echo "+text);
	});

	context.subscriptions.push(disposable);
}

This PR fixes #108301

[rheh]

One suggestion - other than that code looks good.

[rheh]

Perfect

[Tyriar]

Sorry for not getting to this, it looks like someone on the team got to it in the meantime in #110509