Force keybindings header to behave differently from rows

[usernamehw]

Fixes #41558

Header was reacting to L/M/R mouse clicks and touch events. Now it doesn't.

The only questionable thing is focus border around .monaco-list:focused when you click on header after input.

[sandy081]

@usernamehw Thanks for the fix. But instead of doing some CSS hacks I would suggest to render the header separately by removing it out from the list. This will be helpful if we want to implement sorting by clicking the header

[usernamehw]

Adding a header is not a problem, removing one...

I got an error from RowCache
https://github.com/Microsoft/vscode/blob/1b77525993ccdd82a40b7a4e3ba874c5a2eb7a5a/src/vs/base/browser/ui/list/rowCache.ts#L40

"Cannot read property 'renderTemplate' of undefined"

Does RowCache auto clears on vscode update? Is there a way to clear it once? Any other way?

[sandy081]

@usernamehw I meant to implement the header separately without making it part of List widget.

[usernamehw]

@sandy081, That's exactly what I did. When you delete the header - the entire list no longer renders. Deletion from here:
https://github.com/Microsoft/vscode/blob/21cf602a6e1761edbce55474c20357fd482159ff/src/vs/workbench/parts/preferences/browser/keybindingsEditor.ts#L335

Removing new KeybindingHeaderRenderer(), from the line above results in RowCache error - list not rendered at all.

I will push a commit then, it's just before header deletion from the list; New header is added, old header not possible to remove for me. This is not a finished version, stopped right after error encountered.

[sandy081]

@usernamehw You have to remove the code that populate header elements in the list. Ref: https://github.com/microsoft/vscode/blob/master/src/vs/workbench/parts/preferences/browser/keybindingsEditor.ts#L388

[usernamehw]

Should I close this?

[sandy081]

@usernamehw Not yet merged. May I know if your changes are ready to review?

[usernamehw]

Hope so. The last commit was ~2 month ago. I don't even know if this code is working now.