Closed
Conversation
Member
Member
|
Is this the same as #77121? |
Author
|
Yes this is! I just realized, except you forgot to check for iframe and web view again in another section of code, so I did that for better state management. I just now have to wait for approval! |
Member
|
@mjbvz Can you also check this one out? |
ghost
closed this
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally, we were only selecting iframes, which were in webviews. However, this made selecting webviews inaccessible because we were not selecting the iframes. As a result, I modified the selection method to select both iframes and webviews and put those tags in a single collection to enumerate through.