Don't link combase.dll on win7 target#3791
Closed
roblabla wants to merge 1 commit intomicrosoft:masterfrom
Closed
Conversation
Collaborator
Contributor
Author
|
This project is absolutely foundational to the Rust ecosystem. I understand not wanting to advertise or provide win7 support yourself, but why refuse to pull a simple patch that fixes the immediate defect with no impact to the normal rust targets? Especially for a crate whose only purpose is providing language bindings, this seems to have minimal maintenance impact. I saw the suggestion after I did the change, but this requires every app that wants a win7 build to pull this patch, greatly reducing the usefulness of the Rust win7 target. I hope you will reconsider this position. |
This was referenced Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #3743 was merged, win7 builds have been broken due to linking functions from the combase.dll which doesn't exist on win7 (the functions are instead in ole32.dll).
This PR fixes the issue by checking for target_vendor to chose whether to link against ole32 or combase.