This repository was archived by the owner on Aug 26, 2022. It is now read-only.
bug 1401246: Replace dbgettext with management command#4669
Merged
escattone merged 2 commits intomdn:masterfrom Feb 28, 2018
Merged
bug 1401246: Replace dbgettext with management command#4669escattone merged 2 commits intomdn:masterfrom
escattone merged 2 commits intomdn:masterfrom
Conversation
Add generate_search_names management command to extract search Filter and FilterGroups from the database, so that they can be translated for the search UI. This replaces the similar string extraction provided by dbgettext.
dbgettext is not well maintained, and uses a auto-discover routine that is incompatible with AppConfig-style applications. Translatable strings have been moved to kuma/search/names.py, refreshed from the database.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
django-dbgettext was used to extract the
FilterandFilterGroupnames from the database and create files so that they would be picked up as localizable strings. There's a few issues:kuma/core/translations.FilterandFilterGroupout of the database and into code. I'd like to avoid UI strings defined in the database in the future (I'm looking at you,DocumentTag).This PR:
django-dbgettext, output files, and configuration.generate_search_names.kuma/search/names.pywith the current names from production.NAME: "jinja2"to theTEMPLATESsetting, so that I can get the Jinja2 engine by that name rather than the defaultbackend.