This repository was archived by the owner on Aug 26, 2022. It is now read-only.
bug 951180: Position labels after checkboxes#4682
Merged
jwhitlock merged 1 commit intomdn:masterfrom Feb 26, 2018
donovanglover:label-after-checkbox-951180
Merged
bug 951180: Position labels after checkboxes#4682jwhitlock merged 1 commit intomdn:masterfrom donovanglover:label-after-checkbox-951180
jwhitlock merged 1 commit intomdn:masterfrom
donovanglover:label-after-checkbox-951180
Conversation
jwhitlock
approved these changes
Feb 26, 2018
Contributor
jwhitlock
left a comment
jwhitlock
left a comment
There was a problem hiding this comment.
I ran this locally, and the layout is visually the same before and after this change:
I'd like to have the checkbox label a few pixels higher, but that issue was there before this change, so that's a new PR.
Thanks, @gloverdonovan!
| <ul> | ||
| <li id="field-beta" class="field"> | ||
| <label for="{{ user_form.beta.id_for_label }}">{{ user_form.beta.label }}</label> {{ user_form.beta }} | ||
| {{ user_form.beta }} |
Contributor
There was a problem hiding this comment.
I think this is cleaner on its own line - good change!
Contributor
Author
There was a problem hiding this comment.
Glad I could help!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes 951180.
Feel free to tell me if I missed anything. I could only find two checkboxes on the edit page.
No styling changes should be needed. I tested my changes with Developer Tools and both versions behaved the same.