Add Compile to service_slim and pub-sub pattern#9
Closed
alfonsogarciacaro wants to merge 26 commits intoncave:service_slimfrom
Closed
Add Compile to service_slim and pub-sub pattern#9alfonsogarciacaro wants to merge 26 commits intoncave:service_slimfrom
alfonsogarciacaro wants to merge 26 commits intoncave:service_slimfrom
Conversation
* add debug emit docs * add debug emit docs * add debug emit docs * add debug emit docs * add debug emit docs * add debug emit docs * add debug emit docs
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Vlad Zarytovskii <[email protected]>
* fix non-nested mutrec bindings * fix non-nested mutrec bindings * fix non-nested mutrec bindings * fix non-nested mutrec bindings
* Add try and with keywords to SynExpr.TryWith. * Add match and with keywords to SynExpr.Match. * Add match and with keywords to SynExpr.MatchBang. * Add with keyword to SynExpr.ObjExpr and SynInterfaceImpl. * Add with keyword to SynTypeDefnKind.Augmentation. * Add with keyword to SynMemberDefn.Interface. * Add with keyword to SynTypeDefnSig and SynExceptionSig. * Add with keyword to SynMemberDefn.AutoProperty. * Add with keyword to SynValSig. * Add with keyword to SynPat.LongId for SynMemberDefn.Member. * Corrected FSharpCodeAnalysisExtensions.fs * Fix failing unit tests. * Revert some named pattern matches. Renamed Range to range. Add comment above PropertyKeyword. * Correct failing type check tests. * Renamed unused values in pattern match.
…otnet#12423) * add tests * add more tests
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
… Build ID 1480730 (dotnet#12433)
Co-authored-by: Gauthier Segay <[email protected]> Co-authored-by: Gauthier Segay <[email protected]>
… Build ID 1481000 (dotnet#12436)
…ied (dotnet#12430) * don't suppress tailcalls in pipeline debugging if tailcalls are on * don't suppress tailcalls in pipeline debugging if tailcalls are on
… Build ID 1481545 (dotnet#12435) * Localized file check-in by OneLocBuild Task: Build definition ID 499: Build ID 1480996 * Localized file check-in by OneLocBuild Task: Build definition ID 499: Build ID 1480996 * Localized file check-in by OneLocBuild Task: Build definition ID 499: Build ID 1481545 * Localized file check-in by OneLocBuild Task: Build definition ID 499: Build ID 1481545 Co-authored-by: Kevin Ransom (msft) <[email protected]>
* Added CI job for deterministic builds * Attempt to fix deterministic checks * Turn off rebuild * Update test-determinism.ps1 Co-authored-by: Vlad Zarytovskii <[email protected]>
Owner
|
@alfonsogarciacaro I cherry-picked your commit as you suggested, so closing this PR. Sounds like a great improvement, thank you!
|
Author
|
Ah, you're right! For some reason I didn't think of that possibility 😅 There would be some overhead as we have to hit the cache many more times (and maybe some more extra work to initialize and create the project results). Probably it won't be noticeable but if you're ok with the callback, we can leave it as is for now 👍 I will rebranch from your fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes discussed in the following PRs:
Strange, I thought I had the same commits from dotnet/fsharp in my fork than in yours @ncave, but maybe I rebased it again later. In any case, the only commit that matters is the last one, so you can cherry-pick it if you prefer 👍