Skip to content

File Provider Localization #8489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
i2h3 wants to merge 1 commit into from
Closed

File Provider Localization #8489

i2h3 wants to merge 1 commit into from

Conversation

@i2h3
Copy link
Collaborator

@i2h3 i2h3 commented Jul 28, 2025 •
edited
Loading

  • Updated macOS integration project to use localized string resources instead of unlocalized string literals.
  • Three new resources must be created on Transifex before this can be integrated. Can @Rello do that due to required privileges? The updated Transifex configuration file provides more information on the expected identifiers.
  • Info.plist (manifests), of which there are one for each the file provider extension and the file provider UI extension, require a dedicated localization resource. This is a constraint imposed by the platform.
  • I translated German by myself for verification of the functionality.

@i2h3 i2h3 self-assigned this Jul 28, 2025
@i2h3 i2h3 force-pushed the file-provider-localization branch from 9e8fcd9 to d7473e5 Compare July 28, 2025 14:34
@i2h3 i2h3 added this to the 3.17.0 milestone Jul 31, 2025
@i2h3 i2h3 force-pushed the file-provider-localization branch from d7473e5 to be0adea Compare July 31, 2025 08:31
@github-actions
Copy link

github-actions bot commented Jul 31, 2025

Artifact containing the AppImage: nextcloud-appimage-pr-8489.zip

SHA256 checksum: e9c600c0b404de6976acd273578161e7d7d62a105a46303ffa502fa3c447f662

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 31, 2025

Quality Gate Passed Quality Gate passed

Issues
Image 0 New issues
Image 0 Accepted issues

Measures
Image 0 Security Hotspots
Image 0.0% Coverage on New Code
Image 0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@i2h3 i2h3 closed this Jul 31, 2025
@i2h3 i2h3 deleted the file-provider-localization branch July 31, 2025 12:31
@i2h3 i2h3 mentioned this pull request Jul 31, 2025
Merged
@Rello Rello moved this to ☑️ Done in 💻 Desktop Clients team Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Aiiaiiio Aiiaiiio Awaiting requested review from Aiiaiiio Aiiaiiio will be requested when the pull request is marked ready for review Aiiaiiio is a code owner

@camilasan camilasan Awaiting requested review from camilasan camilasan will be requested when the pull request is marked ready for review camilasan is a code owner

@mgallien mgallien Awaiting requested review from mgallien mgallien will be requested when the pull request is marked ready for review mgallien is a code owner

@nilsding nilsding Awaiting requested review from nilsding nilsding will be requested when the pull request is marked ready for review nilsding is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

@i2h3 i2h3

Labels

feature: 💽 virtual filesystem feature: 👅 language l10n and translations os: 🍎 macOS

Projects

None yet

Milestone

3.17.0

Development

Successfully merging this pull request may close these issues.

2 participants

@i2h3