Closed
Conversation
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
solracsf
approved these changes
Jan 27, 2025
Member
|
Since we're using similar logic on the file (empty check) function could be simplified to: |
come-nc
approved these changes
Jan 28, 2025
juliusknorr
approved these changes
Jan 28, 2025
Member
|
Conflicts with #50326 where I asked for the adjustment 🙈 |
4 tasks
Member
Author
|
Let's continue here: #50514 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Setting the
sse_c_keyto an empty string enables encryption despite no key actually being available.Have a look at the following usage:
server/lib/private/Files/ObjectStore/S3ConnectionTrait.php
Lines 224 to 228 in abd7958
Checklist