feat(config): allow to override some config values by hostname#55904
Closed
feat(config): allow to override some config values by hostname#55904
Conversation
8b1db2e to
1bf4677
Compare
d187a2e to
a62c8b2
Compare
1bf4677 to
a03b66f
Compare
1c78c60 to
6766d0a
Compare
a03b66f to
33dd6b2
Compare
6766d0a to
4b1fce7
Compare
ae7d14e to
336cc3f
Compare
artonge
reviewed
Oct 29, 2025
Contributor
artonge
left a comment
There was a problem hiding this comment.
Sorry, mostly comments about the snowflake part 🐵
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
33dd6b2 to
36ce481
Compare
Collaborator
Author
|
Adding variables specific to server in the configuration seems risky for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allows to set configuration based on hostname.
With this PR, we can have a unique server ID for Snowflake IDs, easily linked to the right server.
Variable priority
serverid(and other host defined variables) will be taken from:$CONFIG_HOSTNAME)$CONFIG)TODO
serveridwith environment variableChecklist
3. to review, feature component)stable32)