Improve wording for login throttle warning#56763
Improve wording for login throttle warning#56763himehatsumi wants to merge 2 commits intonextcloud:masterfrom
Conversation
himehatsumi
requested review from
artonge,
skjnldsv and
szaimen
and removed request for
a team
szaimen
added
3. to review
| } | ||
| if (this.throttleDelay > 5000) { | ||
| return t('core', 'We have detected multiple invalid login attempts from your IP. Therefore your next login is throttled up to 30 seconds.') | ||
| return t('core', 'Too many incorrent login attempts. Please try again in 30 seconds.') |
There was a problem hiding this comment.
I find the original message more informative. It lets the user know that the slowdown is caused by failed attempts from their own IP address.
There was a problem hiding this comment.
Someone in the issue said that they would also be okay with just "Try again in 30 seconds." I thought this version would add a bit more clarity but improve upon the current message even if it may be more informative.
|
should be properly fixed now i think? |
|
cc @nextcloud/designers for an input |
nimishavijay
left a comment
nimishavijay
left a comment
There was a problem hiding this comment.
Much more clear now :) We can keep the "Too many incorrect login attempts" as it helps specify what is the issue 👍
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Looks good to me, simpler and less technical/scary wording and still keeps the essence.
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Signed-off-by: himehatsumi <95652868+himehatsumi@users.noreply.github.com>
|
@himehatsumi There are still a few clean-ups to do in the commits before order to merge your PR.
You can take inspiration from #57176 |
8 participants
Summary
Simplify the login throttling warning message shown after multiple failed login attempts.
The original message was long and potentially confusing. This update replaces it with a concise, user-friendly version.
TODO
LoginForm.vueChecklist
3. to review, feature component)32.xforstable32)