Add getVisitorsForNode() method to NodeTraverser#1122
Open
samsonasik wants to merge 5 commits intonikic:masterfrom
Open
Add getVisitorsForNode() method to NodeTraverser#1122samsonasik wants to merge 5 commits intonikic:masterfrom
samsonasik wants to merge 5 commits intonikic:masterfrom
Conversation
Contributor
Author
|
Ready for review 👍 |
|
In the case of Rector, this was used to optimise the running time by 20-30%. Probably other tools could benefit from similar optimisations |
Contributor
|
The 20-30 % speedup was really noticable across many mid-large size projects 👍 |
nikic
reviewed
Oct 20, 2025
Owner
|
It looks like adding this method makes NodeTraverser itself about 10% slower. |
Contributor
Author
|
@nikic could you share script to verify the benchmark? Thank you. |
Contributor
Author
|
@nikic I created benchmark repo for non-cached vs cached node visitor version https://github.com/samsonasik/php-parser-with-cache-node-visitor-benchmark which shows faster result on total time.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

@TomasVotruba here for your request rectorphp/rector-src#6232 (comment)
This is template config for
getVisitorsForNode(), which on rector use case, we use for caching visitor by node.https://github.com/rectorphp/rector-src/blob/4b30bc5d10e7c79867a6a13da3a75a1b2c844675/src/PhpParser/NodeTraverser/RectorNodeTraverser.php#L65-L82
so we can just override the method there :), we currently using vendor-patch for it:
https://github.com/rectorphp/vendor-patches/blob/18e174cbea7beaccb140cfcf03cca3097e95ee92/patches/nikic-php-parser-lib-phpparser-nodetraverser-php.patch
Original PR for this usage for caching on Rector side: