-
-
Notifications
You must be signed in to change notification settings - Fork 34.4k
src,deps,build,test: add OpenSSL config appname #43124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Review requested:
|
|
@danbev this will be breaking for anybody currently depending on the default config right? |
Yeah, this will probably break for them and they would have to copy, or rename, the default section/appname from |
BethGriggs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could/should we also add a flag to allow the old behaviour of loading from the shared section of the OpenSSL config? (maybe --openssl-shared-config or something more suitably named?)
b718d95 to
59870a3
Compare
82c3f44 contains your suggestion (at least my interpretation :) for adding such a flag. |
This commit adds the setting of an appname (configuration section
name),
nodejs_conf, to be used when reading OpenSSL configurationfiles.
The motivation for this is that currently the default OpenSSL
configuration,
openssl_conf, element will be used which may beundesirable as it might configure OpenSSL in unwanted ways. With this
commit it is still possible to use a default openssl.cnf file but the
only section that Node.js will read from is a section named
nodejs_conf.Refs: #40366