Closed
Conversation
Contributor
|
I'm open to it. Need to also change the |
Naming the executable of this library `which` can cause issues -- such as microsoft/vscode#82552. I would like to suggest renaming this executable to `node-which`, so that people can clearly differentiate between built-in `which` (bash, zsh, etc) and the Node version.
Contributor
Author
|
Thanks for being open to it! I've just changed |
Contributor
Author
|
@isaacs is there anything else that I need to do for this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Naming the executable of this library
whichcan cause issues -- such as microsoft/vscode#82552.I would like to suggest renaming this executable to
node-which, so that people can clearly differentiate between built-inwhich(bash, zsh, etc) and the Node version.