(missing base branch) fix: render default arg/opt if equal to 0#248
Closed
akwodkiewicz wants to merge 1 commit intooclif:masterfrom
Closed
(missing base branch) fix: render default arg/opt if equal to 0#248akwodkiewicz wants to merge 1 commit intooclif:masterfrom
akwodkiewicz wants to merge 1 commit intooclif:masterfrom
Conversation
|
Thanks for the contribution! Before we can merge this, we need @akwodkiewicz to sign the Salesforce.com Contributor License Agreement. |
Author
|
Judging by no closing comment and the recent activity on this repo, is #263 going to fix the issue? |
Contributor
|
Oh, hey @akwodkiewicz. Sorry, I didn't close this manually. I switched the primary branch over to Please reopen it against |
Author
|
I believe I don't have the required permissions to re-open the PR 😞 EDIT: so I created #264 |
akwodkiewicz
changed the title
Contributor
|
Yeah, sorry poor choice of words. Nobody can re-open a PR if it's against a deleted branch. I meant recreate it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes rendering of default values for arguments and flags.
Before the fix, if an arg/flag default was set to
0, it was not rendered.