Fix undefined array key "created"#458
Closed
BjornValkOptimizers wants to merge 2 commits intoopenai-php:mainfrom
Closed
Fix undefined array key "created"#458BjornValkOptimizers wants to merge 2 commits intoopenai-php:mainfrom
BjornValkOptimizers wants to merge 2 commits intoopenai-php:mainfrom
Conversation
…' attribute when using Azure OpenAI
iBotPeaches
requested changes
Apr 8, 2025
Collaborator
iBotPeaches
left a comment
iBotPeaches
left a comment
There was a problem hiding this comment.
I'm a bit torn on this. If this is a specific difference of OpenAI on Azure vs main, then we should talk about making some of these nullable.
Since keeping the typing happy with just check after check to fallback to a 0 doesn't seem right. Either way CI failed because the ?? aren't going to work when its typed to always be there.
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the instance of Models RetrieveResponse not containing 'created' attribute when using Azure OpenAI
What:
Description:
Fix an exception when calling client->models()->list() with an Azure OpenAI configuration.
The Azure OpenAI does not return created and owned_by in it's response. Instead use created_at for the created property and an empty string for the ownedBy property
Related:
#457