Fix shell completion for nested groups #2907
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to extract the args from the fresh context when following nested groups to keep 8.1.8 behavior for shell completion for nested groups.
Member
|
Please don't open PRs from a fork owned by a different organization rather than your account. It causes GitHub to disable the ability for maintainers to push changes, so I can't update this to prepare it for merge. Closing and will open a separate PR with your commits. |
Contributor
Author
Sorry about that, I wasn't aware of that. Maybe this could be something to add in https://palletsprojects.com/contributing/pr so that new contributors can avoid this pitfall. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to extract the args from the fresh context when following nested groups to keep 8.1.8 behavior for shell completion in nested groups
fixes #2906