refactor: Sidebar collapse#1269
Closed
douglasmuraoka wants to merge 4 commits intoparse-community:masterfrom
Closed
refactor: Sidebar collapse#1269douglasmuraoka wants to merge 4 commits intoparse-community:masterfrom
douglasmuraoka wants to merge 4 commits intoparse-community:masterfrom
Conversation
Member
|
@douglasmuraoka thanks for working on this. Few questions:
|
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Danger run resulted in 1 fail and 1 markdown; to find out more, see the checks page. Generated by 🚫 dangerJS |
|
Please merge this. The dashboard sidebar needs a Fix. |
Member
|
@tehsunnliu Thanks for bringing this to our attention. I think it just needs a rebase on master, then we can merge it. I'll look into that. |
Member
|
There are some fixed necessary, continued in #1760 |
|
Hi @mtrezza Thank you so much for initiating this. I'll check this out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Removes the old
SidebarTogglecomponent and allows users to collapse the sidebar even when window width is greater than 980px. Adds aPinbutton that fixes the sidebar, avoiding any collapses.Once collapsed, expands the sidebar when on mouse over, and collapses on mouse leave.
Collapsed:

Expanded:

Closes #1759.