[IGNORE] Fixing CI Issue, Add Indexes to Schema API#4322
Closed
montymxb wants to merge 9 commits intoparse-community:masterfrom
Closed
[IGNORE] Fixing CI Issue, Add Indexes to Schema API#4322montymxb wants to merge 9 commits intoparse-community:masterfrom
montymxb wants to merge 9 commits intoparse-community:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4322 +/- ##
==========================================
+ Coverage 92.52% 92.62% +0.09%
==========================================
Files 118 118
Lines 8256 8374 +118
==========================================
+ Hits 7639 7756 +117
- Misses 617 618 +1
Continue to review full report at Codecov.
|
2098348 to
8ee6e44
Compare
Contributor
Author
|
Resolved issue. Found to be an uncaught error being returned when attempting to auto-update the schema with indexes on startup, particularly with default classes Nothing definitively indicates why this only showed up in the CI, but I believe it had to do with some degree of timing. Adjusting local tests so that the auto-addition of indexes was done a bit later caused this error to show up in numerous places locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a CI issue with #4240 that does not appear to manifest locally. I've created this PR to attempt to isolate the issue in the CI specifically. I also cleaned up the commit history.
This is just to diagnose and identify the issue, once it has been identified I'll close this back out.