Add include option to Login

[dplewis]

#288

Parse previously didn't have any way to get all pointer data a User class might have on login, unnecessarily requiring an additional call to get full pointer objects.

Let me know if there is a better way to implement it.

[flovilmart]

Sorry but I really hate it :(

[dplewis]

I noticed there were a lot of things going on the the User class as well. There may be a lot of issue that would arise in the future.

Which part do you dislike?

[flovilmart]

That it’s kinda messy... the login method is to acquire a sessionToken, the fact there’s a user attached is actually a ‘side effect’. The thing that matters on login is not the user but the token....

[dplewis]

Ah I see your point, makes sense.

[flovilmart]

While I agree this is a bit shitty, that post login, you may wanna run a fetch with includes.

Which makes me think, that we don’t support fetch with includes in the SDK. What do you say we add it?

[dplewis]

If you use include you don't have to fetch right?

I'm currently using fetch without include on user login on iOS. Thats why I made this PR.

Ive had it this way for a few years and early on I ran into deadlock issues when I went to refresh users. It always bugged me that I had to use fetch.

[flovilmart]

What I mean, is that on iOS, calling object.fetch() doesn’t let you specify a list of keys to include.

[dplewis]

Oh, thats interesting. How do you see it being implemented in the SDK, the fetch with keys?

Also I always wondered is fetch faster than query.get()

[flovilmart]

Those are the exact same calls BUT, the query let you be a bit more expressive with includes

[codecov]

Codecov Report

Merging #4845 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4845      +/-   ##
==========================================
+ Coverage   92.81%   92.82%   +0.01%     
==========================================
  Files         119      119              
  Lines        8813     8827      +14     
==========================================
+ Hits         8180     8194      +14     
  Misses        633      633

Impacted Files	Coverage Δ
src/Routers/UsersRouter.js	94.19% <100%> (+0.57%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cdbde2...0492df4. Read the comment docs.

[dplewis]

@flovilmart Should we close this one?

[flovilmart]

Let’s not close it :) in the end, it may be useful if we add it with the login options .

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.