Don't trigger beforeSave on login#623
Closed
simonbengtsson wants to merge 1 commit intoparse-community:masterfrom
simonbengtsson:master
Closed
Don't trigger beforeSave on login#623simonbengtsson wants to merge 1 commit intoparse-community:masterfrom simonbengtsson:master
simonbengtsson wants to merge 1 commit intoparse-community:masterfrom
simonbengtsson:master
Conversation
Contributor
|
Looks it needs some rebasing, but I agree with restoring the proper intention of not using triggering |
Contributor
Author
|
With the latest updates I am not seeing this anymore and beforeSave is not called on login. |
Contributor
|
Awesome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Parse iOS SDK (and maybe others?) sends a "create user request" even though the user already exists. Basically using a create request to login. It is handled in parse-server right now by short circuiting the request:
The problem is that this check happens after the beforeSave is triggered which means it will be triggered for every login. This PR fixes that and short circuits before the beforeSave is called.
One side effect of this PR is that the beforeSave is not triggered when authData, username or password is invalid. I thought this made sense, but it might be up for discussion.
This PR brings
parse-servercloser toparse.comas beforeSave was not called on login there.