Become on non existing user#741
Become on non existing user#741flessard wants to merge 1 commit intoparse-community:masterfrom flessard:become-on-non-existing-user
Conversation
Fix bug where become return invalid session if the pointer to user doesn't exist
|
We may wanna destroy the session when user gets deleted instead no? @drew-gross what do you think? |
|
Destroying session for deleted user seems to make sense, yes. Have you checked what Parse.com does? Also I recall some issue where the SDKs would start failing when their session was destroyed, so maybe that's why we didn't destroy it. |
|
If user is deleted, session token should be invalidated at least. @flessard can you check the current behavior on parse.com or you want me to check it out? Other thing to check is to see when calling include on a key and the included object don't exist. Should the pointer getting soft-deleted from the response? I would tend to say so. |
|
@flovilmart Yes if you can check it out, i would appreciate it. I agree whit you @flovilmart, if the pointer getting don't exist, Should soft-deleted from the response. |
|
@flessard so I can confirm that missing includes are resolved to undefined, and that the pointer object is not forwarded to the client. When not calling include on the key, the pointer is still there in the client. |
|
Superseded by #777 |
Fix bug where become return invalid session if the pointer to user
doesn't exist