Voidify some Zend APIs

[Girgias]

These always return SUCCESS and therefore the result is meaningless.

I didn't act on the add_next_index_*() functions as they return zend_hash_next_index_insert(...) but from my understanding this function should also always return SUCCESS.

[Girgias]

@nikic can I merge this, and I imagine this needs an entry in UPGRADING.INTERNALS correct?

[Jan-E]

This PR & commits caused a fatal error when compiling the sqlsrv and pdo_sqlsrv extensions under PHP 8.
Can you document the change in UPGRADING_INTERNALS?

https://github.com/microsoft/msphpsql/blob/master/source/shared/core_sqlsrv.h#L2540-L2546

    inline void sqlsrv_add_assoc_zval( _Inout_ sqlsrv_context& ctx, _Inout_ zval* array_z, _In_ const char* key, _In_ zval* val TSRMLS_DC )
    {
        int zr = ::add_assoc_zval(array_z, key, val);
        CHECK_ZEND_ERROR (zr, ctx, SQLSRV_ERROR_ZEND_HASH ) {
            throw CoreException();
        }
    }

[Girgias]

This PR & commits caused a fatal error when compiling the sqlsrv and pdo_sqlsrv extensions under PHP 8.
Can you document the change in UPGRADING_INTERNALS?

https://github.com/microsoft/msphpsql/blob/master/source/shared/core_sqlsrv.h#L2540-L2546

    inline void sqlsrv_add_assoc_zval( _Inout_ sqlsrv_context& ctx, _Inout_ zval* array_z, _In_ const char* key, _In_ zval* val TSRMLS_DC )
    {
        int zr = ::add_assoc_zval(array_z, key, val);
        CHECK_ZEND_ERROR (zr, ctx, SQLSRV_ERROR_ZEND_HASH ) {
            throw CoreException();
        }
    }

The add_assoc_zval call can't fail anymore so it's just a matter of dropping the check.
This is already documented in UPGRADING_INTERNALS under section t. 1. first dash

[Jan-E]

Forget the 'please document it'. I see that you already did that.

[Jan-E]

OK, so the new code for PHP 8 should be

    inline void sqlsrv_add_assoc_zval( _Inout_ sqlsrv_context& ctx, _Inout_ zval* array_z, _In_ const char* key, _In_ zval* val TSRMLS_DC )
    {
        add_assoc_zval(array_z, key, val);
    }

[Girgias]

OK, so the new code for PHP 8 should be

    inline void sqlsrv_add_assoc_zval( _Inout_ sqlsrv_context& ctx, _Inout_ zval* array_z, _In_ const char* key, _In_ zval* val TSRMLS_DC )
    {
        add_assoc_zval(array_z, key, val);
    }

That's correct :)