fix ifdefs for non-windows systems without long double#5840
Closed
chuckadams wants to merge 1 commit intomasterfrom
unknown repository
Closed
fix ifdefs for non-windows systems without long double#5840chuckadams wants to merge 1 commit intomasterfrom unknown repository
chuckadams wants to merge 1 commit intomasterfrom
unknown repository
Conversation
chuckadams
changed the title
nikic
approved these changes
Jul 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In ext/c/ffi.c, there is an #ifdef on line 70:
Then later on line 315:
A similar inconsistency occurs on line 362. This should be changed to #ifdef HAVE_LONG_DOUBLE, else it will fail to compile on any non-windows system when HAVE_LONG_DOUBLE is undefined.
This doesn't actually come up in normal compilation on Linux, only when I was fiddling with the build system and neglected to include the proper headers. So in some sense it's developer error, but it still ought to be corrected.