Fixed asgiref version for Python 3.8#1053
Closed
andy-maier wants to merge 1 commit intoprometheus:masterfrom
Closed
Fixed asgiref version for Python 3.8#1053andy-maier wants to merge 1 commit intoprometheus:masterfrom
andy-maier wants to merge 1 commit intoprometheus:masterfrom
Conversation
Details: * Needed to pin asgiref to ==3.6.0 also for py3.8 to circumvent the same error as for pypy3.8. Signed-off-by: Andreas Maier <maiera@de.ibm.com>
Member
|
Yeah, since that PR and others are working my guess is we're ok without this now... Going to close but will open and merge if we run into issues in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
Note: This was previously in PR #1019 and was moved into its own PR.
Since the other PRs currently all succeed on Python 3.8, I'm not sure this change is needed anymore.