Skip to content

bpo-40066: Enum global repr doctest #25116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ethanfurman wants to merge 21 commits into from
Closed

bpo-40066: Enum global repr doctest #25116

ethanfurman wants to merge 21 commits into from

Conversation

@ethanfurman
Copy link
Member

@ethanfurman ethanfurman commented Mar 31, 2021 •
edited by bedevere-bot
Loading

@ethanfurman
add new repr and str for converted Int-Enums/Flags
aa436ed
@ethanfurman
wip
db0386f
@ethanfurman
make Enum.__str__ print name or value
33cfa20 
non-StrEnum `__str__` will print the member name
StrEnum `__str__` will print the member value
@ethanfurman
add news entry
bdffc7d
@ethanfurman
fix tests that checked Enum str()
1bd8a6a
@ethanfurman
wip
dfe01a1 
create enum._stdlib_enum decorator for Enums created the normal way: it
adjusts `__repr__` and `__str__` to be the same as if the Enum had been
created using `_convert_`

update various modules to use the new decorator
@ethanfurman
fix format for global string override
2a5ace6 
if `enum.__str__` is either `Enum.__str__` or `global_enum_str` use the
value's `__format__`
@ethanfurman
update docs with new stdlib enum reprs and strs
722474d
@ethanfurman
plain Enum has updated str() and repr()
49a46d0 
repr() = class.member_name
str() = member_name
@ethanfurman
_stdlib_enum -> global_enum
e01379c 
rename to `global_enum` and have `global_enum` update the module's
namespace with the members

remove `_stdlib_enum` where the enums were not being exported to the
module's namespace
@ethanfurman
fix pydoc and unicode tests
893c636
@ethanfurman
fix white space
6ffaf77
@ethanfurman
fix signal tests
9f0ab8b
@ethanfurman
update NEWS entry
d782de0
@ethanfurman
use .__dict__ instead of vars()
1013cea
@ethanfurman
wip
896b608
@ethanfurman
minor updates
4f43964 
* rename global_int_repr --> global_enum_repr
* adjust global_flag_repr to print hex number for out-of-range values
* extract function when _generate_next_value_ is a static method
@ethanfurman
rewrite enum docs; add enum how-to
40910ea
@ethanfurman
Enum: streamline repr() and str(); improve docs
7643863 
- repr() is now ``enum_class.member_name``
- str() is now ``member_name``
- add HOW-TO section for ``Enum``
- change main documentation to be an API reference
@ethanfurman
add whatsnew entry
2b3a5cc
@ethanfurman
Enum: add superfluous reimport for doctest
88b0da6
@ethanfurman ethanfurman requested a review from tiran as a code owner March 31, 2021 14:31
@ethanfurman ethanfurman changed the title Enum global repr doctest bpo-40066: Enum global repr doctest Mar 31, 2021
@ethanfurman ethanfurman deleted the enum-global_repr-doctest branch March 31, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiran tiran Awaiting requested review from tiran

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ethanfurman @the-knights-who-say-ni @bedevere-bot